[webkit-reviews] review requested: [Bug 69669] WebKit2/Shared/APIClient.h complains that array subscript is below array bounds : [Attachment 110674] Added a check for non-negative value for array's index

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 12 05:45:22 PDT 2011


Rafael Brandao <rafael.lobo at openbossa.org> has asked  for review:
Bug 69669: WebKit2/Shared/APIClient.h complains that array subscript is below
array bounds
https://bugs.webkit.org/show_bug.cgi?id=69669

Attachment 110674: Added a check for non-negative value for array's index
https://bugs.webkit.org/attachment.cgi?id=110674&action=review

------- Additional Comments from Rafael Brandao <rafael.lobo at openbossa.org>
I've googled a bit about this warning and I've found out that sometimes the
compiler make some optimizations on the code and the access on arrays may be
negative values after these changes (sources:
http://www.mail-archive.com/gcc@gcc.gnu.org/msg46397.html and
http://gcc.gnu.org/ml/gcc/2009-09/msg00270.html). So I've just added a check
for non-negative values for that index and it has stopped complaining. :)


More information about the webkit-reviews mailing list