[webkit-reviews] review denied: [Bug 69619] [Chromium] select box dropdown list backgound colour error : [Attachment 110507] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 12 02:52:52 PDT 2011
Kent Tamura <tkent at chromium.org> has denied Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 69619: [Chromium] select box dropdown list backgound colour error
https://bugs.webkit.org/show_bug.cgi?id=69619
Attachment 110507: Updated patch
https://bugs.webkit.org/attachment.cgi?id=110507&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110507&action=review
> Source/WebCore/css/themeChromiumLinux.css:40
> - background-color: #f7f7f7;
> + background-color: rgba(247,247,247,0);
I don't think this is correct at all.
Why is it reasonable to make <option> transparent by default?
You have to find a real reason of the regression, and fix it.
> Source/WebCore/manual-tests/item-background.html:74
> - <div class="swatch"></div>
> + <div class="sblack"></div>
I understand this is expected color for other browsers. How about
Safari/Windows and Chromium/Windows?
More information about the webkit-reviews
mailing list