[webkit-reviews] review granted: [Bug 67625] Clean up CSSPropertyTextDecoration implementation and ETextDecoration usage. : [Attachment 107954] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 67625: Clean up CSSPropertyTextDecoration implementation and
ETextDecoration usage.
https://bugs.webkit.org/show_bug.cgi?id=67625

Attachment 107954: Patch
https://bugs.webkit.org/attachment.cgi?id=107954&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107954&action=review


> Source/WebCore/rendering/style/RenderStyleConstants.h:339
> +static const size_t ETextDecorationBits = 4;

If we don't need this broken out like this, I think it's better to not use a
constant here.	It makes it more difficult to tell how large RenderSTyle is.

> Source/WebCore/rendering/style/StyleVisualData.h:52
> +    unsigned textDecoration : ETextDecorationBits; // Text decorations
defined *only* by this element.

I see, you want to re-use it here.  OK.