[webkit-reviews] review requested: [Bug 58608] Groove/inset/outset borders show solid if the color is black : [Attachment 110641] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 11 23:14:49 PDT 2011
Antaryami Pandia <xqb748 at motorola.com> has asked for review:
Bug 58608: Groove/inset/outset borders show solid if the color is black
https://bugs.webkit.org/show_bug.cgi?id=58608
Attachment 110641: Updated patch
https://bugs.webkit.org/attachment.cgi?id=110641&action=review
------- Additional Comments from Antaryami Pandia <xqb748 at motorola.com>
Updated patch.
Using "baseDarkColor" and "baseLightColor" color to determine whether a color
is on darker side or lighter side.
For e.g. if the color has a value which is between black and baseDarkColor,
then its assumed that it's a darker color.
Please note that the values of "baseDarkColor" and "baseLightColor" are set
based on some observation and can be modified.
More information about the webkit-reviews
mailing list