[webkit-reviews] review denied: [Bug 66878] HTMLAudioElement can be garbage collected while it playing : [Attachment 110585] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Eugene Nalimov
<enal at google.com>'s request for review:
Bug 66878: HTMLAudioElement can be garbage collected while it playing
https://bugs.webkit.org/show_bug.cgi?id=66878

Attachment 110585: Patch
https://bugs.webkit.org/attachment.cgi?id=110585&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110585&action=review


> Source/WebCore/html/HTMLMediaElement.h:61
> -class HTMLMediaElement : public HTMLElement, public MediaPlayerClient,
private MediaCanStartListener, private ActiveDOMObject {
> +class HTMLMediaElement : public HTMLElement, public MediaPlayerClient,
private MediaCanStartListener, public ActiveDOMObject {

I think the plan is to stop inheriting from ActiveDOMObject in
HTMLMediaElement.

> LayoutTests/fast/xpath/xpath-result-eventlistener-crash.html:29
> -    for (var i = 0; i < 5000; ++i)
> +    for (var i = 0; i < 2000; ++i)

Please don't make unrelated tests weaker.