[webkit-reviews] review denied: [Bug 69867] [Chromium] Allow building without speech input enabled. : [Attachment 110610] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 69867: [Chromium] Allow building without speech input enabled.
https://bugs.webkit.org/show_bug.cgi?id=69867

Attachment 110610: Patch
https://bugs.webkit.org/attachment.cgi?id=110610&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110610&action=review


> Source/WebCore/page/SpeechInputListener.h:-34
> -#if ENABLE(INPUT_SPEECH)

I don't understand why you are removing these guards.  Don't we want
to prevent this code from being seen when people are not interested
in building with INPUT_SPEECH enabled?

> Tools/DumpRenderTree/chromium/LayoutTestController.cpp:90
> +#if ENABLE(INPUT_SPEECH)

I would not expect to see any DumpRenderTree changes since DumpRenderTree
just consumes WebKit via the WebKit API, and the API entrypoints exist
regardless of the value of ENABLE(INPUT_SPEECH).