[webkit-reviews] review denied: [Bug 69589] [chromium] Let rule_binding use os.execvp() instead of subprocess.call() to spawn fewer processes. : [Attachment 110605] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied  review:
Bug 69589: [chromium] Let rule_binding use os.execvp() instead of
subprocess.call() to spawn fewer processes.
https://bugs.webkit.org/show_bug.cgi?id=69589

Attachment 110605: Patch
https://bugs.webkit.org/attachment.cgi?id=110605&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110605&action=review


> Source/WebCore/WebCore.gyp/scripts/rule_binding.py:132
> +    else:

since os.execvp() doesn't return, you can delete this else and outdent the
following code. You can also delete the trailing else, which is just incorrect.