[webkit-reviews] review denied: [Bug 69028] Add getSubstringFromRange() and selectionRange() for chromium : [Attachment 110547] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Peng Huang
<penghuang at chromium.org>'s request for review:
Bug 69028: Add getSubstringFromRange() and selectionRange() for chromium
https://bugs.webkit.org/show_bug.cgi?id=69028

Attachment 110547: Patch
https://bugs.webkit.org/attachment.cgi?id=110547&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110547&action=review


> Source/WebKit/chromium/public/WebWidget.h:154
> +    virtual WebString getSubstringFromRange(size_t location, size_t length)
const { return WebString(); }

shouldn't this just be a method on WebRange?  it seems like we should be using
WebRange
for more of these range related APIs.  we should also be providing ways to get
a WebRange
or construct a WebRange.