[webkit-reviews] review denied: [Bug 69867] [Chromium] Allow building without speech input enabled. : [Attachment 110569] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 69867: [Chromium] Allow building without speech input enabled.
https://bugs.webkit.org/show_bug.cgi?id=69867

Attachment 110569: Patch
https://bugs.webkit.org/attachment.cgi?id=110569&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110569&action=review


> Source/WebKit/chromium/public/WebSpeechInputListener.h:34
> +#if ENABLE_INPUT_SPEECH

we don't put ENABLE_ options in WebKit API headers.  chromium doesn't see
config.h.

these should only be used in the .cpp files to protect against using WebCore
classes and functions that are only defined under ENABLE_INPUT_SPEECH.