[webkit-reviews] review granted: [Bug 69874] WebKit2 snapshot APIs should take the device scale factor into account : [Attachment 110591] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 69874: WebKit2 snapshot APIs should take the device scale factor into
account
https://bugs.webkit.org/show_bug.cgi?id=69874

Attachment 110591: Patch
https://bugs.webkit.org/attachment.cgi?id=110591&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110591&action=review


> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:945
> +    float deviceScaleFactor = corePage()->deviceScaleFactor();

Given that the code below repeatedly multiplies this by the scale factor and
never uses the device scale factor alone, I’d suggest instead:

    float combinedScaleFactor = scaleFactor * corePage()->deviceScaleFactor();