[webkit-reviews] review granted: [Bug 69737] [Qt] GeolocationClient cleanups : [Attachment 110324] The patch: removed using namespaces in the header file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 11 14:44:43 PDT 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Adenilson
Cavalcanti Silva <adenilson.silva at openbossa.org>'s request for review:
Bug 69737: [Qt] GeolocationClient cleanups
https://bugs.webkit.org/show_bug.cgi?id=69737

Attachment 110324: The patch: removed using namespaces in the header file
https://bugs.webkit.org/attachment.cgi?id=110324&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110324&action=review


Please fix changelog before landing

> Source/WebKit/qt/ChangeLog:6
> +	   Fixmes: remove of using namespace in header file.

What does this mean? The patch is imcomplete? or you fixed some fixme's?


More information about the webkit-reviews mailing list