[webkit-reviews] review granted: [Bug 69863] DFG JIT 32_64 - Switch to cdecl calling convention. : [Attachment 110570] The patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 11 14:20:51 PDT 2011
Oliver Hunt <oliver at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 69863: DFG JIT 32_64 - Switch to cdecl calling convention.
https://bugs.webkit.org/show_bug.cgi?id=69863
Attachment 110570: The patch
https://bugs.webkit.org/attachment.cgi?id=110570&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110570&action=review
r=me, fix the spelling error and the sizeof<SPACE!!!!>( style error
> Source/JavaScriptCore/ChangeLog:8
> + This makes it easier to keep the stack correctly aligned, which is
reuired on OS X.
required.
r-!!!!!111!!!1!!!111!1
> Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h:1060
> + m_jit.move(Imm32(numConstants), GPRInfo::argumentGPR2);
> + m_jit.move(Imm32(startConstant), GPRInfo::argumentGPR1);
well caught sir!
>> Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h:1252
>> + m_jit.storeDouble(value,
JITCompiler::Address(JITCompiler::stackPointerRegister, m_callArgumentIndex *
sizeof (void*)));
>
> Extra space before ( in function call [whitespace/parens] [4]
This is a real style bug in the sizeof
More information about the webkit-reviews
mailing list