[webkit-reviews] review denied: [Bug 69846] [chromium] Add a setSelectionOnFocusedFrame() method to WebWidget. : [Attachment 110527] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 11 13:01:06 PDT 2011
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Nico Weber
<thakis at chromium.org>'s request for review:
Bug 69846: [chromium] Add a setSelectionOnFocusedFrame() method to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=69846
Attachment 110527: Patch
https://bugs.webkit.org/attachment.cgi?id=110527&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110527&action=review
> Source/WebKit/chromium/public/WebWidget.h:115
> + virtual void setSelectionOnFocusedFrame(int selectionStart,
nit: WebWidget is not supposed to know about WebFrame. You can use a WebWidget
that has no concept of frames. Maybe you want to have this be a method on
WebView, which does know about frames?
next question: perhaps you should just add a method to WebFrame. then, use
view->focusedFrame()->setSelectionRange(int selectionStart, int selectionEnd).
what are the coordinates of selectionStart and selectionEnd? should you be
using WebRange to express the range? It looks like your implementation needs
to construct a WebCore::Range (which WebRange wraps).
i guess my overall suggestion is to consider exposing primitives here instead.
More information about the webkit-reviews
mailing list