[webkit-reviews] review denied: [Bug 69844] Disable border radius clips (r95239) for Chromium due to performance issues. : [Attachment 110524] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Tom Hudson
<tomhudson at google.com>'s request for review:
Bug 69844: Disable border radius clips (r95239) for Chromium due to performance
issues.
https://bugs.webkit.org/show_bug.cgi?id=69844

Attachment 110524: Patch
https://bugs.webkit.org/attachment.cgi?id=110524&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110524&action=review


> Source/WebCore/rendering/RenderLayer.cpp:2588
> +#if !PLATFORM(CHROMIUM)
>      // If the clip rect has been tainted by a border radius, then we have to
walk up our layer chain applying the clips from
>      // any layers with overflow. The condition for being able to apply these
clips is that the overflow object be in our
>      // containing block chain so we check that also.

Can't you just #ifdef out the one line that sets the taint bit?

We really dislike seemingly arbitrary platform #ifdefs. It's impossible to
tell, by reading the code, that this was disabled for perf reasons. It would be
much better to work on a solution to the performance issue.