[webkit-reviews] review denied: [Bug 69817] [skia] Implement Path.currentPoint for skia : [Attachment 110476] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 11 10:35:21 PDT 2011


Kenneth Russell <kbr at google.com> has denied Ben Wells <benwells at chromium.org>'s
request for review:
Bug 69817: [skia] Implement Path.currentPoint for skia
https://bugs.webkit.org/show_bug.cgi?id=69817

Attachment 110476: Patch
https://bugs.webkit.org/attachment.cgi?id=110476&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110476&action=review


Looks fine but there's a problem with the ChangeLog that will cause it to be
rejected from the commit queue.

> Source/WebCore/ChangeLog:10
> +	   No new tests. (OOPS!)

You'll need to remove this OOPS line. Also ideally there would be a test case.


More information about the webkit-reviews mailing list