[webkit-reviews] review denied: [Bug 69840] Fix build with GLib 2.31 : [Attachment 110514] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Tomeu Vizoso
<tomeu.vizoso at collabora.co.uk>'s request for review:
Bug 69840: Fix build with GLib 2.31
https://bugs.webkit.org/show_bug.cgi?id=69840

Attachment 110514: Patch
https://bugs.webkit.org/attachment.cgi?id=110514&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
This partially defeats the purpose of the GTypedefs.h header, which was
intended mainly to avoid including glib.h and a few other headers, and is
lacking a ChangeLog entry (I know, it sucks) which you can generate with
./Tools/Scripts/prepare-ChangeLog.

I see two ways going forward:

1 - give up on avoiding including glib (and then removing all of the relevant
typedefs)
2 - stop using GMutex; there was some discussion in webkit-dev about dropping
non-pthread/non-win32 implementations, I wonder if we could just go that route?