[webkit-reviews] review denied: [Bug 68540] ParallelJobs: maximum number of threads should be determined dynamically : [Attachment 108309] Patch v3

[bugzilla-daemon at webkit.org]

Zoltan Herczeg <zherczeg at webkit.org> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 68540: ParallelJobs: maximum number of threads should be determined
dynamically
https://bugs.webkit.org/show_bug.cgi?id=68540

Attachment 108309: Patch v3
https://bugs.webkit.org/attachment.cgi?id=108309&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108309&action=review


> Source/JavaScriptCore/wtf/ParallelJobsGeneric.cpp:51
> +    const int defaultIfNotAvailable = 2;

defaultIfUnavailable

> Source/JavaScriptCore/wtf/ParallelJobsGeneric.h:59
> -	   for (unsigned int i = 0; i < maxParallelThreads && m_threads.size()
< maxNewThreads; ++i) {
> +	   for (unsigned int i = 0; i < s_maxNumberOfParallelThreads &&
m_threads.size() < maxNewThreads; ++i) {

Signed unsigned comparison? Surprising that VC does not complain.

I think we should change all variables to ints. It is highly unlikely that in
the near future we have systems with more than 2 billion cores.