[webkit-reviews] review canceled: [Bug 69343] [GTK] Initial implementation of back forward list for WebKit2 GTK+ API : [Attachment 110130] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 11 03:09:10 PDT 2011


Carlos Garcia Campos <cgarcia at igalia.com> has canceled Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 69343: [GTK] Initial implementation of back forward list for WebKit2 GTK+
API
https://bugs.webkit.org/show_bug.cgi?id=69343

Attachment 110130: Updated patch
https://bugs.webkit.org/attachment.cgi?id=110130&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
- Use a HashMap instead of a GHashTable for list items, this way we don't need
the cast
- Add tests for can_go_back and can_go_forward, since these methods depend on
the back forward list too.


More information about the webkit-reviews mailing list