[webkit-reviews] review granted: [Bug 38787] Incorrect rendering with one-sided thick border and border-radius : [Attachment 110457] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ben Wells
<benwells at chromium.org>'s request for review:
Bug 38787: Incorrect rendering with one-sided thick border and border-radius
https://bugs.webkit.org/show_bug.cgi?id=38787

Attachment 110457: Patch
https://bugs.webkit.org/attachment.cgi?id=110457&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110457&action=review


> LayoutTests/fast/borders/border-radius-complex-inner.html:10
> +    display: inline-block;
> +    border: 5px #00F solid;
> +    width: 20px;
> +    height: 20px;
> +    padding: 0px;
> +    margin: 10px;

Please make everything bigger, more like the mixed-border-styles-radius tests,
so that failures are more obvious in pixel tests.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:2258
> +    // Expand the inner border as necessary to make it a rounded rect (i.e.
radii contained within each
> +    // edge).

Unfortunate wrapping.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:2337
> +void
RenderBoxModelObject::clipBorderSideForComplexInnerPath(GraphicsContext*
graphicsContext, const RoundedRect& outerBorder, const RoundedRect&
innerBorder,
> +								BoxSide side,
const class BorderEdge edges[])

In new code we don't try to align stuff like this. Just indent the second line
by 4 spaces, or unwrap it.