[webkit-reviews] review granted: [Bug 69812] Move m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement : [Attachment 110462] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 10 20:07:46 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 69812: Move m_listItems and m_recalcListItems from SelectElementData to
HTMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=69812

Attachment 110462: Patch 2
https://bugs.webkit.org/attachment.cgi?id=110462&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110462&action=review


> Source/WebCore/html/HTMLSelectElement.cpp:645
> +void HTMLSelectElement::checkListItems() const
> +{

It's unfortunate that we'll end up calling this function even in release builds
:(


More information about the webkit-reviews mailing list