[webkit-reviews] review granted: [Bug 69779] media/audio-data-url.html test broken on Lion : [Attachment 110421] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 10 17:44:31 PDT 2011
Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 69779: media/audio-data-url.html test broken on Lion
https://bugs.webkit.org/show_bug.cgi?id=69779
Attachment 110421: Patch
https://bugs.webkit.org/attachment.cgi?id=110421&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110421&action=review
> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:285
> + if (!willUseProxy && ![[cocoaURL scheme] compare:@"data"
options:NSCaseInsensitiveSearch]) {
Is there any reason to not use WebCore's protocolIs() or KURL's
protocolIsData() instead?
More information about the webkit-reviews
mailing list