[webkit-reviews] review granted: [Bug 69790] Make CachedResourceClient a base class, with specialized callbacks in subclasses : [Attachment 110433] patch without diamond inheritance

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 69790: Make CachedResourceClient a base class, with specialized callbacks
in subclasses
https://bugs.webkit.org/show_bug.cgi?id=69790

Attachment 110433: patch without diamond inheritance
https://bugs.webkit.org/attachment.cgi?id=110433&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110433&action=review


> Source/WebCore/loader/cache/CachedFont.cpp:83
> -	   c->fontLoaded(this);
> +	   static_cast<CachedFontClient*>(c)->fontLoaded(this);

I wish there was a way to check this cast.