[webkit-reviews] review granted: [Bug 69677] De-virtualize JSCell::toString : [Attachment 110398] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 10 14:10:28 PDT 2011
Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 69677: De-virtualize JSCell::toString
https://bugs.webkit.org/show_bug.cgi?id=69677
Attachment 110398: Patch
https://bugs.webkit.org/attachment.cgi?id=110398&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110398&action=review
> Source/JavaScriptCore/ChangeLog:9
> + Removed toString from JSCallbackObject, since it is no
> + longer necessary.
Why is it no longer necessary? Because conversion to string is handled in
defaultValue? Some other reason?
> Source/JavaScriptCore/runtime/ExceptionHelpers.cpp:50
> + return JSValue(std::numeric_limits<double>::quiet_NaN());
Should not need "std::" here since it’s in a cpp file and we normally use
“using namespace std” in those.
> Source/JavaScriptCore/runtime/ExceptionHelpers.cpp:75
> + return JSValue(std::numeric_limits<double>::quiet_NaN());
Ditto.
> Source/JavaScriptGlue/ChangeLog:8
> + Removed UserObjectImp::toString since it's no longer necessary.
Again, why is it no longer necessary?
More information about the webkit-reviews
mailing list