[webkit-reviews] review denied: [Bug 69412] REGRESSIoN (r95399): Web process hangs when opening documents on Google Docs : [Attachment 110392] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 10 13:43:48 PDT 2011
Oliver Hunt <oliver at apple.com> has denied Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 69412: REGRESSIoN (r95399): Web process hangs when opening documents on
Google Docs
https://bugs.webkit.org/show_bug.cgi?id=69412
Attachment 110392: the patch
https://bugs.webkit.org/attachment.cgi?id=110392&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110392&action=review
>> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:688
>> + if (false) return false;
>
> More than one command on the same line in if [whitespace/parens] [4]
This seems unlikely to be correct...
>> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:707
>> + if (false) return false;
>
> More than one command on the same line in if [whitespace/parens] [4]
:D
>> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:711
>> + if (false) return false;
>
> More than one command on the same line in if [whitespace/parens] [4]
:D
> Source/JavaScriptCore/jit/JIT.cpp:540
> -#if ENABLE(DFG_JIT)
> - if (m_canBeOptimized)
> - m_startOfCode = label();
> +#if ENABLE(DFG_JIT) || ENABLE(JIT_VERBOSE)
> + m_startOfCode = label();
Shouldn't this be if (m_canBeOptimized || ENABLE(JIT_VERBOSE)) ?
More information about the webkit-reviews
mailing list