[webkit-reviews] review granted: [Bug 69575] Extract WebOpenPanelResultListener out into its own file : [Attachment 110061] [PATCH] Extract WebOpenPanelListener into its own file
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 10 12:26:49 PDT 2011
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 69575: Extract WebOpenPanelResultListener out into its own file
https://bugs.webkit.org/show_bug.cgi?id=69575
Attachment 110061: [PATCH] Extract WebOpenPanelListener into its own file
https://bugs.webkit.org/attachment.cgi?id=110061&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110061&action=review
>> Source/WebKit/mac/WebCoreSupport/WebOpenPanelResultListener.h:30
>> + class FileChooser;
>
> Code inside a namespace should not be indented. [whitespace/indent] [4]
This one should be fixed.
>> Source/WebKit/mac/WebCoreSupport/WebOpenPanelResultListener.h:34
>> +{
>
> This { should be at the end of the previous line [whitespace/braces] [4]
I think this one can be ignored.
More information about the webkit-reviews
mailing list