[webkit-reviews] review granted: [Bug 52092] [Soup] ResourceHandleSoup does not handle encodedBlobData : [Attachment 109445] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 52092: [Soup] ResourceHandleSoup does not handle encodedBlobData
https://bugs.webkit.org/show_bug.cgi?id=52092

Attachment 109445: Patch
https://bugs.webkit.org/attachment.cgi?id=109445&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109445&action=review


Looks good!

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:597
>      // We have more than one element to upload, and some may be large files,

>      // which we will want to mmap instead of copying into memory

This comment does not hold true anymore, I believe? We don't know that we have
more than one element, do we? =)