[webkit-reviews] review granted: [Bug 69766] Style guide should mandate use of pass-by-reference for out arguments : [Attachment 110368] 'get' prefix only applies to getters

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 69766: Style guide should mandate use of pass-by-reference for out
arguments
https://bugs.webkit.org/show_bug.cgi?id=69766

Attachment 110368: 'get' prefix only applies to getters
https://bugs.webkit.org/attachment.cgi?id=110368&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110368&action=review


Looks great to me.

> Websites/webkit.org/coding/coding-style.html:578
> +<li>Precede getters that return values through out arguments with the word
"get".</li>

I don’t think the phrase “precede getters” is quite right. A getter is a
function, not a function’s name, and the “get” is part of the name, so doesn’t
precede it.

But since the earlier item says “precede setters”, it seems we can fix both
together later.

I’d also use curly quotes instead of straight quotes around "get".