[webkit-reviews] review granted: [Bug 69611] [Qt] WebProcess using proxy settings for localhost as well : [Attachment 110366] proxy fix for localhost

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 10 10:56:54 PDT 2011


Chang Shu <cshu at webkit.org> has granted Gopal Raghavan
<gopal.1.raghavan at nokia.com>'s request for review:
Bug 69611: [Qt] WebProcess using proxy settings for localhost as well
https://bugs.webkit.org/show_bug.cgi?id=69611

Attachment 110366: proxy fix for localhost
https://bugs.webkit.org/attachment.cgi?id=110366&action=review

------- Additional Comments from Chang Shu <cshu at webkit.org>
Excellent patch! For perfection, you can possibly explore the option of
replacing the "localhost" and "127.0.0.1" with some redefined Qt variables and
whether we should go "CaseSensitive". But the patch is good to go.


More information about the webkit-reviews mailing list