[webkit-reviews] review granted: [Bug 69726] Web Inspector: annotate DOMAgent, Debugger(Presentation)Model with types. : [Attachment 110358] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 10 08:33:25 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 69726: Web Inspector: annotate DOMAgent, Debugger(Presentation)Model with
types.
https://bugs.webkit.org/show_bug.cgi?id=69726

Attachment 110358: Patch
https://bugs.webkit.org/attachment.cgi?id=110358&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110358&action=review


> Source/WebCore/inspector/front-end/DebuggerModel.js:389
> +	   this._debuggerModel._parsedScriptSource(scriptId, sourceURL,
startLine, startColumn, endLine, endColumn, isContentScript || false);

!!isContentScript ?

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:573
> +WebInspector.PresentationConsoleMessage.prototype = {

Remove this ?


More information about the webkit-reviews mailing list