[webkit-reviews] review granted: [Bug 69744] Web Inspector: small memory leak in scripts panel : [Attachment 110342] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 10 02:39:56 PDT 2011

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 69744: Web Inspector: small memory leak in scripts panel

Attachment 110342: Patch

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110342&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:435
> +	      
ourceCodeRemoved, this._rawSourceCode[id].sourceMapping.uiSourceCode);

Pavel Podivilov was going to allow for multiple UISourceCode's per single
RawSourceCode, but I assume it is not landed yet. Also we may want to introduce
something like UISourceCodesCleared event for performance reasons., but for now
this approach is fine.

More information about the webkit-reviews mailing list