[webkit-reviews] review requested: [Bug 68499] Extract common gdb code into its own function; Remove script gdb-safari : [Attachment 110321] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 68499: Extract common gdb code into its own function; Remove script
gdb-safari
https://bugs.webkit.org/show_bug.cgi?id=68499

Attachment 110321: Patch
https://bugs.webkit.org/attachment.cgi?id=110321&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
I also changed in runSafari():

my $webKitLauncherPath = File::Spec->catfile(productDir(), "WebKit.exe");
$result = system { $webKitLauncherPath } $webKitLauncherPath, @ARGV;
return $result if $result;

To:

my $webKitLauncherPath = File::Spec->catfile(productDir(), "WebKit.exe");
return system { $webKitLauncherPath } $webKitLauncherPath, @ARGV;

since the former would implicitly return undef if $result was 0 and undef has a
truth value that is equivalent to 0.