[webkit-reviews] review granted: [Bug 69708] Remove "near miss" XSS vulnerabilities in garden-o-matic : [Attachment 110282] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 9 18:58:06 PDT 2011
David Levin <levin at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 69708: Remove "near miss" XSS vulnerabilities in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=69708
Attachment 110282: Patch
https://bugs.webkit.org/attachment.cgi?id=110282&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110282&action=review
>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/ui.js:80
> + if (tab.parentNode != this)
I'm sure this is obvious to you (and maybe to others?), but I don't understand
why this check is need/what it is doing.
Maybe you could add a comment about that (and commit it).
If it is totally obvious, feel free to just add something in the bug and cq+
this.
More information about the webkit-reviews
mailing list