[webkit-reviews] review denied: [Bug 69721] JSVALUE32_64 DFG JIT - Bug fix for ConvertThis : [Attachment 110298] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 9 12:09:58 PDT 2011

Filip Pizlo <fpizlo at apple.com> has denied Yuqiang Xian
<yuqiang.xian at intel.com>'s request for review:
Bug 69721: JSVALUE32_64 DFG JIT - Bug fix for ConvertThis

Attachment 110298: the patch

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
This doesn't look right.  I think you should be catching the case where
thisValueTagGPR holds NullTag.	I think that's what this code was trying to do
(and failing).

More information about the webkit-reviews mailing list