[webkit-reviews] review granted: [Bug 69716] DFG should not always speculate that a ByVal access has an integer index : [Attachment 110295] the patch - another attempt to make stylebot happy

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 69716: DFG should not always speculate that a ByVal access has an integer
index
https://bugs.webkit.org/show_bug.cgi?id=69716

Attachment 110295: the patch - another attempt to make stylebot happy
https://bugs.webkit.org/attachment.cgi?id=110295&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110295&action=review


r=me, but update those comments

> Source/JavaScriptCore/dfg/DFGPropagator.cpp:1025
> +		       // PutByVal currently always speculates that it's
accessing an array with an
> +		       // integer index, which means that it's impossible for
it to cause a structure
> +		       // change.

This comment should be updated to indicate this only applies when integer
properties are being accessed

> Source/JavaScriptCore/dfg/DFGPropagator.cpp:1093
> +		       // PutByVal currently always speculates that it's
accessing an array with an
> +		       // integer index, which means that it's impossible for
it to cause a structure
> +		       // change.

as above

> Source/JavaScriptCore/dfg/DFGPropagator.cpp:1136
> +		       // PutByVal currently always speculates that it's
accessing an array with an
> +		       // integer index, which means that it's impossible for
it to cause a structure
> +		       // change.

ditto

> Source/JavaScriptCore/dfg/DFGPropagator.cpp:1172
> +		       // PutByVal currently always speculates that it's
accessing an array with an
> +		       // integer index, which means that it's impossible for
it to cause a structure
> +		       // change.

ditto