[webkit-reviews] review denied: [Bug 65796] REGRESSION (r91125): Polyline tool in google docs is broken : [Attachment 104828] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 8 22:48:26 PDT 2011

Dirk Schulze <krit at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 65796: REGRESSION (r91125): Polyline tool in google docs is broken

Attachment 104828: Patch

------- Additional Comments from Dirk Schulze <krit at webkit.org>
With renis patch, we will differ between all shapes. So we just need to know
about empty paths on SVGPathElement. Maybe you can get these information from
SVGPathBuilder. You'd just need another boolean value (hasZeroLengthSubPath).
You'd get the necessary information during parsing the path. Of course you
won't parse the path data all the time, just on changes of the path. This way
we wouldn't depend on platform information that might be wrong (after internal
path transformations) or not existent at all.

Also, I'd like to see more test cases with different segment combinations.

More information about the webkit-reviews mailing list