[webkit-reviews] review granted: [Bug 69702] JSVALUE32_64 DFG JIT - Bug fixes for Branch and LogicalNot : [Attachment 110271] the patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Yuqiang Xian
<yuqiang.xian at intel.com>'s request for review:
Bug 69702: JSVALUE32_64 DFG JIT - Bug fixes for Branch and LogicalNot
https://bugs.webkit.org/show_bug.cgi?id=69702

Attachment 110271: the patch
https://bugs.webkit.org/attachment.cgi?id=110271&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110271&action=review


> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:560
>      speculationCheck(m_jit.branch32(MacroAssembler::NotEqual, valueTagGPR,
TrustedImm32(JSValue::UndefinedTag)));

It's sad that we need two branches here. :-(  But I think that we can optimize
this later; more important is that your version is safer and more likely to be
correct.