[webkit-reviews] review requested: [Bug 67329] WebSocket should have EventTarget on the prototype chain : [Attachment 110260] Patch

[bugzilla-daemon at webkit.org]

Dominic Cooney <dominicc at chromium.org> has asked  for review:
Bug 67329: WebSocket should have EventTarget on the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=67329

Attachment 110260: Patch
https://bugs.webkit.org/attachment.cgi?id=110260&action=review

------- Additional Comments from Dominic Cooney <dominicc at chromium.org>
This is ready for review now.

This patch is the first conversion from mixing in EventTarget to putting it on
the prototype chain. So it is a bigger than subsequent patches will be.

The style warnings are not new; they are from moving most of JSEventTarget.cpp
to JSEventTargetCustom.cpp since JSEventTarget is generated now. I am happy to
sort the includes, but it will result in a lot more #ifs and I judge it not to
be worth it.

I would really appreciate it if someone familiar with CodeGeneratorJSC.pm could
look at that part.

There was some friction over this bug earlier, with the suggestion that WebKit
should consider when to make this change. I think we should make it now and
start with this patch.