[webkit-reviews] review granted: [Bug 68853] Need a mechanism to query plugins for scaling to printable area or not. : [Attachment 108775] Add API to indicate if print scaling should be disabled.

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Steve
VanDeBogart <vandebo at chromium.org>'s request for review:
Bug 68853: Need a mechanism to query plugins for scaling to printable area or
not.
https://bugs.webkit.org/show_bug.cgi?id=68853

Attachment 108775: Add API to indicate if print scaling should be disabled.
https://bugs.webkit.org/attachment.cgi?id=108775&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=108775&action=review


> Source/WebKit/chromium/public/WebFrame.h:451
> +    // If the frame or node is a plugin whose content indicates that printed


What does it mean for a frame to be a plugin?  Are you referring to the case of

a full-frame plugin, which has a PluginDocument?  Maybe say "If the frame
contains
a full-frame plugin or the given node refers to a plugin, and the plugin's
content
indicates that printed output..."

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1404
> +    ASSERT(!frame()->document()->isFrameSet());

why do you have this assertion here?

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1412
> +	 return false;

nit: indentation