[webkit-reviews] review granted: [Bug 69663] DFG ConvertThis speculation logic is wrong : [Attachment 110207] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 7 13:37:51 PDT 2011


Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 69663: DFG ConvertThis speculation logic is wrong
https://bugs.webkit.org/show_bug.cgi?id=69663

Attachment 110207: the patch
https://bugs.webkit.org/attachment.cgi?id=110207&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110207&action=review


> Source/JavaScriptCore/dfg/DFGPropagator.cpp:723
> -	       printf("  @%u -> %s", nodeIndex, isArray ? "GetArrayLength" :
"GetStringLength");
> +	       printf("  @%u -> %s", m_compileIndex, isArray ? "GetArrayLength"
: "GetStringLength");

Whoops, my bad


More information about the webkit-reviews mailing list