[webkit-reviews] review granted: [Bug 69613] [GTK] Add methods to reload the view to WebKit2 GTK+ API : [Attachment 110119] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 7 10:48:55 PDT 2011


Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 69613: [GTK] Add methods to reload the view to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69613

Attachment 110119: Patch
https://bugs.webkit.org/attachment.cgi?id=110119&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110119&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:285
> +    WebPageProxy* page =
webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(webView));
> +    WKPageReload(toAPI(page));

Might as well make this one line.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:300
> +    WebPageProxy* page =
webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(webView));
> +    WKPageReloadFromOrigin(toAPI(page));

One line again.


More information about the webkit-reviews mailing list