[webkit-reviews] review granted: [Bug 69503] CSS text-transform should apply to select elements : [Attachment 110096] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 7 08:55:37 PDT 2011
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ben Wells
<benwells at chromium.org>'s request for review:
Bug 69503: CSS text-transform should apply to select elements
https://bugs.webkit.org/show_bug.cgi?id=69503
Attachment 110096: Patch
https://bugs.webkit.org/attachment.cgi?id=110096&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110096&action=review
> Source/WebCore/rendering/RenderMenuList.cpp:385
> + itemString = optionElement->textIndentedToRespectGroupLabel();
> + applyTextTransform(style(), itemString, ' ');
> +
> + return itemString;
I'd prefer the blank line before the applyTextTransform
More information about the webkit-reviews
mailing list