[webkit-reviews] review granted: [Bug 69541] [Qt][WK2] ApplicationCache LayoutTests failed : [Attachment 110003] patch2

[bugzilla-daemon at webkit.org]

Chang Shu <cshu at webkit.org> has granted qi <qi.2.zhang at nokia.com>'s request for
review:
Bug 69541: [Qt][WK2] ApplicationCache LayoutTests failed
https://bugs.webkit.org/show_bug.cgi?id=69541

Attachment 110003: patch2
https://bugs.webkit.org/attachment.cgi?id=110003&action=review

------- Additional Comments from Chang Shu <cshu at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110003&action=review


Please update ChangeLog descriptions before landing.

> Source/WebKit2/ChangeLog:12
> +	   3. Add interface setApplicationCacheDirectory.

It seems we need a better wording here. :) How about this:
1. Moved applicationCacheDirectory to common code.
2. Added interface setApplicationCacheDirectory to allow UI client overriding.
3. Renamed all platform-dependent implementations of applicationCacheDirectory
to platformDefaultApplicationCacheDirectory.
4. On Qt, set the platformDefaultApplicationCacheDirectory to the default data
location.

> LayoutTests/ChangeLog:7
> +

Add "Unskip passed tests." here.