[webkit-reviews] review granted: [Bug 69588] AX: re-organize fake elements to use new AccessibilityMockObject : [Attachment 110072] patch

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 69588: AX: re-organize fake elements to use new AccessibilityMockObject
https://bugs.webkit.org/show_bug.cgi?id=69588

Attachment 110072: patch
https://bugs.webkit.org/attachment.cgi?id=110072&action=review

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110072&action=review


Please fix the build issues before committing. r=me

> Source/WebCore/accessibility/AccessibilityMockObject.h:15
> + * 1.  Redistributions of source code must retain the above copyright
> + *	  notice, this list of conditions and the following disclaimer.
> + * 2.  Redistributions in binary form must reproduce the above copyright
> + *	  notice, this list of conditions and the following disclaimer in the
> + *	  documentation and/or other materials provided with the distribution.
> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> + *	  its contributors may be used to endorse or promote products derived
> + *	  from this software without specific prior written permission.

This has a different version of the license than AccessibilityMockObject.cpp.
We use the two clause version in new code.

> Source/WebCore/accessibility/AccessibilityMockObject.h:41
> +    static PassRefPtr<AccessibilityMockObject> create();

I think you can remove this. I don't see it used or defined.