[webkit-reviews] review granted: [Bug 69340] Web Inspector: saving JavaScript after live edit resets scroller position. : [Attachment 109971] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 69340: Web Inspector: saving JavaScript after live edit resets scroller
position.
https://bugs.webkit.org/show_bug.cgi?id=69340

Attachment 109971: Patch
https://bugs.webkit.org/attachment.cgi?id=109971&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=109971&action=review


> Source/WebCore/inspector/front-end/UISourceCode.js:81
> +    contentChanged: function()

Looking at the current implementation, it seems that we can pass new content as
a parameter here and avoid additional requestContent later.

> Source/WebCore/inspector/front-end/UISourceCode.js:84
> +	   this._contentLoaded = false;

this._content should also be cleared