[webkit-reviews] review granted: [Bug 63706] [GTK] Implement drag and drop support in WebKit2 : [Attachment 110099] Fix the funky licensing on DragIcon.h
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 7 01:13:27 PDT 2011
Philippe Normand <pnormand at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 63706: [GTK] Implement drag and drop support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=63706
Attachment 110099: Fix the funky licensing on DragIcon.h
https://bugs.webkit.org/attachment.cgi?id=110099&action=review
------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110099&action=review
Looks good, please fix this little early return issue and the one earlier
spotted by Carlos before landing!
> Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:60
> + if (bitmap && !bitmap->createHandle(handle))
> + return;
I think this should be:
if (!bitmap || !bitmap->createHandle(handle))
return;
More information about the webkit-reviews
mailing list