[webkit-reviews] review denied: [Bug 68035] [chromium] Zoom animator front-end : [Attachment 110016] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 68035: [chromium] Zoom animator front-end
https://bugs.webkit.org/show_bug.cgi?id=68035

Attachment 110016: Patch
https://bugs.webkit.org/attachment.cgi?id=110016&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110016&action=review


Thanks, looks better but a couple of remaining issues.

> LayoutTests/platform/chromium/compositing/zoom-animator-scale-test2.html:27
> +		   clearInterval(timer);

The layoutTestController won't be notified if this happens. There should be a
clear indication that the test failed in this case. Please test by manually
injecting a failure.

> LayoutTests/platform/chromium/test_expectations.txt:2666
> +BUGWKxxxxx MAC WIN GPU GPU-CG :
platform/chromium/compositing/zoom-animator-scale-test2.html = IMAGE

Could you go ahead and file the follow-on bug so you can reference it here?
(Why doesn't this test work on the other platforms?)

> Source/WebCore/page/FrameView.cpp:70
> +#include "TraceEvent.h"

This is failing the bots. If you're putting it here it needs #if
PLATFORM(CHROMIUM).

> Source/WebCore/page/FrameView.cpp:1236
> +	       TRACE_EVENT("FrameView::zoomAnimatorTransformChanged", this, 0);


PLATFORM(CHROMIUM) needed here.