[webkit-reviews] review granted: [Bug 69468] media/video-loop.html is failing on Lion because of negative currentTime() : [Attachment 110017] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 6 16:07:39 PDT 2011


Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 69468: media/video-loop.html is failing on Lion because of negative
currentTime()
https://bugs.webkit.org/show_bug.cgi?id=69468

Attachment 110017: Patch
https://bugs.webkit.org/attachment.cgi?id=110017&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110017&action=review


>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:435
> +	   float seconds = narrowPrecisionToFloat(CMTimeGetSeconds(itemTime));
> +	   return max(seconds, 0.0f);

Should not need a local variable for this. Probably reads better without it.


More information about the webkit-reviews mailing list