[webkit-reviews] review granted: [Bug 69567] Make IconLoader a CachedResourceClient : [Attachment 110037] patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 69567: Make IconLoader a CachedResourceClient
https://bugs.webkit.org/show_bug.cgi?id=69567

Attachment 110037: patch
https://bugs.webkit.org/attachment.cgi?id=110037&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=110037&action=review


This looks great.  One question: Why "raw" resource instead of "icon" resource?
 Are you planning to use this kind of cached resource for other purposes?

> Source/WebCore/loader/cache/CachedResource.h:139
> +    virtual bool ignoreForRequestCount() const

Why virtual?