[webkit-reviews] review granted: [Bug 69570] DFG should not always speculate that ConvertThis is operating on an object : [Attachment 110042] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 6 15:37:59 PDT 2011


Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 69570: DFG should not always speculate that ConvertThis is operating on an
object
https://bugs.webkit.org/show_bug.cgi?id=69570

Attachment 110042: the patch
https://bugs.webkit.org/attachment.cgi?id=110042&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=110042&action=review


> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:1801
> +	       m_jit.andPtr(MacroAssembler::TrustedImm32(~TagBitUndefined),
scratchGPR);

Does this handle null and undefined?


More information about the webkit-reviews mailing list