[webkit-reviews] review granted: [Bug 45784] Deleting line break before h1 converts h1 to span : [Attachment 109894] fixes the bug for good

[bugzilla-daemon at webkit.org]

Enrica Casucci <enrica at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 45784: Deleting line break before h1 converts h1 to span
https://bugs.webkit.org/show_bug.cgi?id=45784

Attachment 109894: fixes the bug for good
https://bugs.webkit.org/attachment.cgi?id=109894&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=109894&action=review


This looks great. Only one small comment.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:758
> +inline Node* nodeToSplitToAvoidPastingIntoInlineNodesWithStyle(const
Position& insertionPos)

The function name is a bit ugly in my opinion, but very descriptive and that is
what is important!

> Source/WebCore/editing/markup.cpp:366
> +	   }

I would prefer this if else block to be:
if (parentOfHighestNode) {
    if (shouldAnnotate()) {
	 ....
    } else {
	...
    }
}